lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 188/190] Revert "scsi: 3w-xxxx: fix a missing-check bug"
    On Wed, Apr 21, 2021 at 03:01:03PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 9899e4d3523faaef17c67141aa80ff2088f17871.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Wenwen Wang <wang6495@umn.edu>
    > Cc: Adam Radford <aradford@gmail.com>
    > Cc: Martin K. Petersen <martin.petersen@oracle.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/scsi/3w-xxxx.c | 3 ---
    > 1 file changed, 3 deletions(-)
    >
    > diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
    > index d90b9fca4aea..8f52f35e40f1 100644
    > --- a/drivers/scsi/3w-xxxx.c
    > +++ b/drivers/scsi/3w-xxxx.c
    > @@ -1035,9 +1035,6 @@ static int tw_chrdev_open(struct inode *inode, struct file *file)
    >
    > dprintk(KERN_WARNING "3w-xxxx: tw_ioctl_open()\n");
    >
    > - if (!capable(CAP_SYS_ADMIN))
    > - return -EACCES;
    > -
    > minor_number = iminor(inode);
    > if (minor_number >= tw_device_extension_count)
    > return -ENODEV;
    > --
    > 2.31.1
    >

    The original commit was correct, dropping this revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 18:56    [W:2.029 / U:1.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site