lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 118/190] Revert "scsi: ufs: fix a missing check of devm_reset_control_get"
    On Wed, Apr 21, 2021 at 02:59:53PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 63a06181d7ce169d09843645c50fea1901bc9f0a.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Avri Altman <avri.altman@wdc.com>
    > Cc: Martin K. Petersen <martin.petersen@oracle.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/scsi/ufs/ufs-hisi.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
    > index 0aa58131e791..7d1e07a9d9dd 100644
    > --- a/drivers/scsi/ufs/ufs-hisi.c
    > +++ b/drivers/scsi/ufs/ufs-hisi.c
    > @@ -468,10 +468,6 @@ static int ufs_hisi_init_common(struct ufs_hba *hba)
    > ufshcd_set_variant(hba, host);
    >
    > host->rst = devm_reset_control_get(dev, "rst");
    > - if (IS_ERR(host->rst)) {
    > - dev_err(dev, "%s: failed to get reset control\n", __func__);
    > - return PTR_ERR(host->rst);
    > - }
    >
    > ufs_hisi_set_pm_lvl(hba);
    >
    > --
    > 2.31.1
    >

    This commit is incorrect, it does not properly clean up on the error
    path, so I'll keep the revert and fix it up properly.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 18:43    [W:2.150 / U:2.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site