lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 035/190] Revert "scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj"
    On Wed, Apr 21, 2021 at 02:58:30PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 0267ffce562c8bbf9b57ebe0e38445ad04972890.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: https
    > Cc: Lee Duncan <lduncan@suse.com>
    > Cc: Qiushi Wu <wu000273@umn.edu>
    > Cc: Martin K. Petersen <martin.petersen@oracle.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/scsi/iscsi_boot_sysfs.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
    > index a64abe38db2d..e4857b728033 100644
    > --- a/drivers/scsi/iscsi_boot_sysfs.c
    > +++ b/drivers/scsi/iscsi_boot_sysfs.c
    > @@ -352,7 +352,7 @@ iscsi_boot_create_kobj(struct iscsi_boot_kset *boot_kset,
    > boot_kobj->kobj.kset = boot_kset->kset;
    > if (kobject_init_and_add(&boot_kobj->kobj, &iscsi_boot_ktype,
    > NULL, name, index)) {
    > - kobject_put(&boot_kobj->kobj);
    > + kfree(boot_kobj);
    > return NULL;
    > }
    > boot_kobj->data = data;
    > --
    > 2.31.1
    >

    Looks correct so I'll drop this revert.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 18:39    [W:2.764 / U:1.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site