lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 016/190] Revert "drm/nouveau: fix reference count leak in nouveau_debugfs_strap_peek"
    On Wed, Apr 21, 2021 at 02:58:11PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 8f29432417b11039ef960ab18987c7d61b2b5396.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Aditya Pakki <pakki001@umn.edu>
    > Cc: Ben Skeggs <bskeggs@redhat.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
    > index c2bc05eb2e54..c8da70e06006 100644
    > --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
    > +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
    > @@ -54,10 +54,8 @@ nouveau_debugfs_strap_peek(struct seq_file *m, void *data)
    > int ret;
    >
    > ret = pm_runtime_get_sync(drm->dev->dev);
    > - if (ret < 0 && ret != -EACCES) {
    > - pm_runtime_put_autosuspend(drm->dev->dev);
    > + if (ret < 0 && ret != -EACCES)
    > return ret;
    > - }
    >
    > seq_printf(m, "0x%08x\n",
    > nvif_rd32(&drm->client.device.object, 0x101000));
    > --
    > 2.31.1
    >

    Looks correct, dropping this.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 18:26    [W:2.158 / U:2.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site