lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 040/190] Revert "ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe()"
    On Wed, Apr 21, 2021 at 02:58:35PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 4d8be4bc94f74bb7d096e1c2e44457b530d5a170.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Qiushi Wu <wu000273@umn.edu>
    > Cc: 4.10+ <stable@vger.kernel.org> # 4.10+
    > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/acpi/cppc_acpi.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
    > index 69057fcd2c04..42650b34e45e 100644
    > --- a/drivers/acpi/cppc_acpi.c
    > +++ b/drivers/acpi/cppc_acpi.c
    > @@ -830,7 +830,6 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
    > "acpi_cppc");
    > if (ret) {
    > per_cpu(cpc_desc_ptr, pr->id) = NULL;
    > - kobject_put(&cpc_ptr->kobj);
    > goto out_free;
    > }
    >
    > --
    > 2.31.1
    >

    The original change here looks correct, so I will drop this revert from
    my tree.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 16:51    [W:2.109 / U:5.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site