lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 044/190] Revert "RDMA/pvrdma: Fix missing pci disable in pvrdma_pci_probe()"
On Wed, Apr 21, 2021 at 12:25:17PM -0700, Roland Dreier wrote:
> This is a really weird one because the patch actually looks correct
> and the revert looks wrong??
>
> ret = pci_enable_device(pdev);
>
> [...dbg statements...]
>
> if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
> dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
> ret = -ENOMEM;
> goto err_disable_pdev;
> }
>
> - R.

git revert sometimes does odd things :)

I'll go drop this from the tree, thanks.

greg k-h

\
 
 \ /
  Last update: 2021-04-27 16:25    [W:0.218 / U:2.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site