lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] uio: uio_pci_generic: add memory mappings
From
Date
Hi,
The reason for these extra changes is the result of running
fashkar@barbarian:~/Downloads/linux_mainline$ clang-format -style=file
-i drivers/uio/uio_pci_generic.c

fashkar@barbarian:~/Downloads/linux_mainline$ ./scripts/checkpatch.pl
0001-uio-uio_pci_generic-add-memory-mappings.patch

i shall undo those changes and retry again, ty
--
Firas Ashkar
Developpeur Système Embarqué

savoirfairelinux.com | Montréal, Québec

Tél.: +1 514 276 5468 ext. 118





On Tue, 2021-04-27 at 08:20 +0200, Greg KH wrote:
> On Mon, Apr 26, 2021 at 03:03:46PM -0400, Firas Ashkar wrote:
> > import memory resources from underlying pci device, thus allowing
> > userspace applications to memory map those resources.
>
> You also did other things in this patch that have nothing to do with
> this change, why?
>
> Always describe what your patch does properly, otherwise we have to
> ignore it.
>
> > Signed-off-by: Firas Ashkar <firas.ashkar@savoirfairelinux.com>
> > ---
> > :100644 100644 c7d681fef198 809eca95b5bb M drivers/uio/uio_pci_gen
> > eric.c
> > drivers/uio/uio_pci_generic.c | 52 +++++++++++++++++++++++++++++
> > ------
> > 1 file changed, 43 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/uio/uio_pci_generic.c
> > b/drivers/uio/uio_pci_generic.c
> > index c7d681fef198..809eca95b5bb 100644
> > --- a/drivers/uio/uio_pci_generic.c
> > +++ b/drivers/uio/uio_pci_generic.c
> > @@ -24,9 +24,9 @@
> > #include <linux/slab.h>
> > #include <linux/uio_driver.h>
> >
> > -#define DRIVER_VERSION "0.01.0"
> > -#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> > -#define DRIVER_DESC "Generic UIO driver for PCI 2.3
> > devices"
> > +#define DRIVER_VERSION "0.01.0"
> > +#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> > +#define DRIVER_DESC "Generic UIO driver for PCI 2.3 devices"
>
> Like this, why change these lines???
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2021-04-27 16:06    [W:0.073 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site