lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 127/190] Revert "ALSA: sb8: add a check for request_region"
On Wed, Apr 21, 2021 at 06:21:26PM +0200, Takashi Iwai wrote:
> On Wed, 21 Apr 2021 15:00:02 +0200,
> Greg Kroah-Hartman wrote:
> >
> > This reverts commit dcd0feac9bab901d5739de51b3f69840851f8919.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Kangjie Lu <kjlu@umn.edu>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This code change itself looks OK, OTOH, the original commit message is
> slightly wrong: the code path can never result in NULL deference in
> this case, as it's just an optional resource reservation. So, it's
> safe to revert this.

Thanks for the review!

greg k-h

\
 
 \ /
  Last update: 2021-04-27 15:52    [W:0.232 / U:2.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site