lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 023/190] Revert "drm/radeon: fix multiple reference count leak"
On Wed, Apr 21, 2021 at 04:07:14PM +0000, Deucher, Alexander wrote:
> [AMD Public Use]
>
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Sent: Wednesday, April 21, 2021 8:58 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Aditya Pakki
> > <pakki001@umn.edu>; Deucher, Alexander
> > <Alexander.Deucher@amd.com>
> > Subject: [PATCH 023/190] Revert "drm/radeon: fix multiple reference count
> > leak"
> >
> > This reverts commit 6f2e8acdb48ed166b65d47837c31b177460491ec.
> >
> > Commits from @umn.edu addresses have been found to be submitted in
> > "bad faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a paper
> > published at the 42nd IEEE Symposium on Security and Privacy entitled,
> > "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite
> > Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu
> > (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from the
> > kernel tree and will need to be re-reviewed again to determine if they
> > actually are a valid fix. Until that work is complete, remove this change to
> > ensure that no problems are being introduced into the codebase.
> >
> > Cc: Aditya Pakki <pakki001@umn.edu>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> AFAICT, this patch is correct or at least does no harm. Handling of pm_runtime_get_sync() errors in the kernel seems to be inconsistent at best.

Thanks for the review, now dropped.

greg k-h

\
 
 \ /
  Last update: 2021-04-27 15:42    [W:0.200 / U:2.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site