lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 161/190] Revert "staging: rts5208: Add a check for ms_read_extra_data"
    On Wed, Apr 21, 2021 at 03:00:36PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 73b69c01cc925d9c48e5b4f78e3d8b88c4e5b924.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Aditya Pakki <pakki001@umn.edu>
    > Cc: Dan Carpenter <dan.carpenter@oracle.com>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/staging/rts5208/ms.c | 5 +----
    > 1 file changed, 1 insertion(+), 4 deletions(-)
    >
    > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
    > index 9001570a8c94..37b60ba1bdfe 100644
    > --- a/drivers/staging/rts5208/ms.c
    > +++ b/drivers/staging/rts5208/ms.c
    > @@ -1665,10 +1665,7 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,
    > return STATUS_FAIL;
    > }
    >
    > - retval = ms_read_extra_data(chip, old_blk, i, extra,
    > - MS_EXTRA_SIZE);
    > - if (retval != STATUS_SUCCESS)
    > - return STATUS_FAIL;
    > + ms_read_extra_data(chip, old_blk, i, extra, MS_EXTRA_SIZE);
    >
    > retval = ms_set_rw_reg_addr(chip, OVERWRITE_FLAG,
    > MS_EXTRA_SIZE, SYSTEM_PARAM, 6);
    > --
    > 2.31.1
    >

    This one looks fine, I'm dropping it.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 13:57    [W:2.597 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site