lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] rds: Remove redundant assignment to nr_sig
    Date
    Variable nr_sig is being assigned a value however the assignment is
    never read, so this redundant assignment can be removed.

    Cleans up the following clang-analyzer warning:

    net/rds/ib_send.c:297:2: warning: Value stored to 'nr_sig' is never read
    [clang-analyzer-deadcode.DeadStores].

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    ---
    net/rds/ib_send.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
    index 92b4a86..4190b90 100644
    --- a/net/rds/ib_send.c
    +++ b/net/rds/ib_send.c
    @@ -294,7 +294,6 @@ void rds_ib_send_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc)

    rds_ib_ring_free(&ic->i_send_ring, completed);
    rds_ib_sub_signaled(ic, nr_sig);
    - nr_sig = 0;

    if (test_and_clear_bit(RDS_LL_SEND_FULL, &conn->c_flags) ||
    test_bit(0, &conn->c_map_queued))
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2021-04-27 12:26    [W:4.345 / U:2.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site