lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 06/79] media: exynos-gsc: don't resume at remove time
    Date
    Calling pm_runtime_get_sync() at driver's removal time is not
    needed, as this will resume PM runtime. Also, the PM runtime
    code at pm_runtime_disable() already calls it, if it detects
    the need.

    So, simplify the code by getting rid of that.

    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    ---
    drivers/media/platform/exynos-gsc/gsc-core.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c
    index 9f41c2e7097a..70e86cdc1012 100644
    --- a/drivers/media/platform/exynos-gsc/gsc-core.c
    +++ b/drivers/media/platform/exynos-gsc/gsc-core.c
    @@ -1210,8 +1210,6 @@ static int gsc_remove(struct platform_device *pdev)
    struct gsc_dev *gsc = platform_get_drvdata(pdev);
    int i;

    - pm_runtime_get_sync(&pdev->dev);
    -
    gsc_unregister_m2m_device(gsc);
    v4l2_device_unregister(&gsc->v4l2_dev);

    @@ -1219,7 +1217,6 @@ static int gsc_remove(struct platform_device *pdev)
    for (i = 0; i < gsc->num_clocks; i++)
    clk_disable_unprepare(gsc->clock[i]);

    - pm_runtime_put_noidle(&pdev->dev);
    pm_runtime_disable(&pdev->dev);

    dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-27 12:15    [W:8.020 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site