lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop iteration
Date
> Subject: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop
> iteration
>
> Early exits from for_each_available_child_of_node() should decrement the
> node reference counter. Reported by Coccinelle:
>
> drivers/thermal/imx_sc_thermal.c:93:1-33: WARNING:
> Function "for_each_available_child_of_node" should have of_node_put()
> before return around line 97.
>

Reviewed-by: Jacky Bai <ping.bai@nxp.com>

BR
Jacky Bai

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/thermal/imx_sc_thermal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c
> b/drivers/thermal/imx_sc_thermal.c
> index b01d28eca7ee..8d76dbfde6a9 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device
> *pdev)
> for_each_available_child_of_node(np, child) {
> sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
> if (!sensor) {
> + of_node_put(child);
> of_node_put(sensor_np);
> return -ENOMEM;
> }
> @@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(struct
> platform_device *pdev)
> dev_err(&pdev->dev,
> "failed to get valid sensor resource id: %d\n",
> ret);
> + of_node_put(child);
> break;
> }
>
> @@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(struct
> platform_device *pdev)
> if (IS_ERR(sensor->tzd)) {
> dev_err(&pdev->dev, "failed to register thermal zone\n");
> ret = PTR_ERR(sensor->tzd);
> + of_node_put(child);
> break;
> }
>
> --
> 2.25.1

\
 
 \ /
  Last update: 2021-04-27 10:56    [W:0.048 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site