lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] iomap: new code for 5.13-rc1
On Tue, Apr 27, 2021 at 12:40:09PM -0700, Linus Torvalds wrote:
> We have '%pD' for printing a filename. It may not be perfect (by
> default it only prints one component, you can do "%pD4" to show up to
> four components), but it should "JustWork(tm)".
>
> And if it doesn't, we should fix it.
>
> So instead of having a kmalloc/kfree for the path buffer, I think you
> should have been able to just do
>
> pr_err("swapon: file %pD4 %s\n", isi->file, str);
>
> and be done with it.

I'm aware of %pD, but 4 components here are not enough. People
need to distinguish between xfstests runs and something real in
the system for these somewhat scary sounding messages.

\
 
 \ /
  Last update: 2021-04-27 21:58    [W:0.127 / U:5.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site