Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 27 Apr 2021 09:05:43 +0200 | Subject | Re: [PATCH v1 3/3] Revert "Revert "driver core: Set fw_devlink=on by default"" |
| |
Hi Florian,
On Mon, Apr 26, 2021 at 11:48 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > On 4/26/21 2:33 PM, Saravana Kannan wrote: > > On Mon, Apr 26, 2021 at 1:51 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > >> On 3/2/21 1:11 PM, Saravana Kannan wrote: > >>> This reverts commit 3e4c982f1ce75faf5314477b8da296d2d00919df. > >>> > >>> Since all reported issues due to fw_devlink=on should be addressed by > >>> this series, revert the revert. fw_devlink=on Take II. > >>> > >>> Signed-off-by: Saravana Kannan <saravanak@google.com> > >> > >> This change breaks booting on SCMI-based platforms such as ARCH_BRCMSTB. > >> If I revert this change or boot with fw_devlink=permissive, then our > >> systems boot again. From a quick look, the SCMI clock provider was never > >> probed which means that our UART driver never got a chance to get its > >> clock and we have no console -> timeout. > > > > We explicitly landed changes to handle this condition. So we'll see if > > this is what is happening. > > > >> Al, AFAICT you had started to analyze this before in the context of > >> SCMI, do you mind sharing what you had found? > >> > >> Saravana, is there any debugging output that we can help provide? > > > > Thanks for the report. Couple of things that can help: > > 1. Example DTS file (the final board file so that I can get the full DT view). > > Attached BCX972160DV.dts which is one such system. > > > 2. Point out the UART device node and the SCMI device node that you > > suspect is causing the issue. > > The SCMI provider node is brcm_scmi@0 and its sub-node protocol@14 is > the clock provider. The UART node is /rdb/serial@840c000.
I guess dependencies on SCMI sub-nodes are not handled correctly?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |