Messages in this thread | | | From | Namhyung Kim <> | Subject | [PATCHSET v2 0/6] perf report: Make --stat output more compact | Date | Mon, 26 Apr 2021 18:37:11 -0700 |
| |
Hello,
This patchset changes the output of perf report --stat.
Changes from v1) * fix build error in TUI (Jiri) * print percentage of each event (Andi)
The perf report --stat shows event statistics like below:
$ perf report --stat
Aggregated stats: TOTAL events: 20064 MMAP events: 239 LOST events: 0 COMM events: 1518 EXIT events: 1 THROTTLE events: 0 UNTHROTTLE events: 0 FORK events: 1517 READ events: 0 SAMPLE events: 4015 MMAP2 events: 12769 AUX events: 0 ITRACE_START events: 0 LOST_SAMPLES events: 0 SWITCH events: 0 SWITCH_CPU_WIDE events: 0 NAMESPACES events: 0 KSYMBOL events: 0 BPF_EVENT events: 0 CGROUP events: 0 TEXT_POKE events: 0 ATTR events: 0 EVENT_TYPE events: 0 TRACING_DATA events: 0 BUILD_ID events: 0 FINISHED_ROUND events: 2 ID_INDEX events: 0 AUXTRACE_INFO events: 0 AUXTRACE events: 0 AUXTRACE_ERROR events: 0 THREAD_MAP events: 1 CPU_MAP events: 1 STAT_CONFIG events: 0 STAT events: 0 STAT_ROUND events: 0 EVENT_UPDATE events: 0 TIME_CONV events: 1 FEATURE events: 0 COMPRESSED events: 0
But it's too long and mostly 0 so we can make it more compact. Also perf report -D has similar output at the end with each event's sample count. It'd be better if we can have the same output in both case.
So I added --skip-empty (and --no-skip-empty automatically) to suppres the 0 output and add the event stats like below.
$ perf report --stat --skip-empty
Aggregated stats: TOTAL events: 20064 MMAP events: 239 ( 1.2%) COMM events: 1518 ( 7.6%) EXIT events: 1 ( 0.0%) FORK events: 1517 ( 7.6%) SAMPLE events: 4015 (20.0%) MMAP2 events: 12769 (63.6%) FINISHED_ROUND events: 2 ( 0.0%) THREAD_MAP events: 1 ( 0.0%) CPU_MAP events: 1 ( 0.0%) TIME_CONV events: 1 ( 0.0%) cycles stats: SAMPLE events: 2475 instructions stats: SAMPLE events: 1540
And I make it enabled by default with a new config option report.skip-empty to change the behavior if needed.
Thanks, Namhyung
Namhyung Kim (6): perf top: Use evlist->events_stat to count events perf hists: Split hists_stats from events_stats perf report: Show event sample counts in --stat output perf report: Add --skip-empty option to suppress 0 event stat perf report: Make --skip-empty as default perf report: Print percentage of each event statistics
tools/perf/Documentation/perf-config.txt | 5 ++++ tools/perf/Documentation/perf-report.txt | 3 ++ tools/perf/builtin-annotate.c | 6 ++-- tools/perf/builtin-report.c | 38 ++++++++++++++++++++---- tools/perf/builtin-top.c | 20 +++++-------- tools/perf/tests/hists_filter.c | 14 ++++----- tools/perf/ui/browsers/hists.c | 17 ++++++----- tools/perf/ui/stdio/hist.c | 15 ++++++++-- tools/perf/util/events_stats.h | 13 +++++--- tools/perf/util/hist.c | 26 +++++++++++----- tools/perf/util/hist.h | 7 +++-- tools/perf/util/session.c | 5 ++-- tools/perf/util/session.h | 3 +- 13 files changed, 118 insertions(+), 54 deletions(-)
base-commit: 4c391ea001cb2e7bd9a691a886c0dcb030c1791c -- 2.31.1.527.g47e6f16901-goog
| |