lkml.org 
[lkml]   [2021]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fs/ntfs: drop unneeded assignment in ntfs_perform_write()
Date
It is not required to initialize the local variable idx in
ntfs_perform_write(), the value is never actually read from
it.

make clang-analyzer on x86_64 allyesconfig reports:

fs/ntfs/file.c:1781:15: warning: Although the value stored to 'idx' is
used in the enclosing expression, the value is never actually read from
'idx'

Simplify the code and remove unneeded assignment to make clang-analyzer
happy.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/ntfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index e5aab26..e39a26f 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -1774,11 +1774,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
last_vcn = -1;
do {
VCN vcn;
- pgoff_t idx, start_idx;
+ pgoff_t start_idx;
unsigned ofs, do_pages, u;
size_t copied;

- start_idx = idx = pos >> PAGE_SHIFT;
+ start_idx = pos >> PAGE_SHIFT;
ofs = pos & ~PAGE_MASK;
bytes = PAGE_SIZE - ofs;
do_pages = 1;
--
1.8.3.1
\
 
 \ /
  Last update: 2021-04-25 12:17    [W:0.054 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site