lkml.org 
[lkml]   [2021]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: replace HOTPLUG with UEVENT in FW_ACTION defines
On Sun, Apr 25, 2021 at 08:14:53AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 25, 2021 at 10:00:24AM +0800, Shawn Guo wrote:
> > With commit 312c004d36ce ("[PATCH] driver core: replace "hotplug" by
> > "uevent"") already in the tree over a decade, update the name of
> > FW_ACTION defines to follow semantics, and reflect what the defines are
> > really meant for, i.e. whether or not generate user space event.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > drivers/dma/imx-sdma.c | 2 +-
> > drivers/media/platform/exynos4-is/fimc-is.c | 2 +-
> > drivers/mfd/iqs62x.c | 2 +-
> > drivers/misc/lattice-ecp3-config.c | 2 +-
> > drivers/net/wireless/ti/wlcore/main.c | 2 +-
> > drivers/platform/x86/dell/dell_rbu.c | 2 +-
> > drivers/remoteproc/remoteproc_core.c | 2 +-
> > drivers/scsi/lpfc/lpfc_init.c | 2 +-
> > drivers/tty/serial/ucc_uart.c | 2 +-
> > include/linux/firmware.h | 4 ++--
> > lib/test_firmware.c | 10 +++++-----
> > sound/soc/codecs/wm8958-dsp2.c | 6 +++---
> > 12 files changed, 19 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> > index d5590c08db51..e2b559945c11 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -1829,7 +1829,7 @@ static int sdma_get_firmware(struct sdma_engine *sdma,
> > int ret;
> >
> > ret = request_firmware_nowait(THIS_MODULE,
> > - FW_ACTION_HOTPLUG, fw_name, sdma->dev,
> > + FW_ACTION_UEVENT, fw_name, sdma->dev,
>
> Naming is hard :)
>
> I can take this after -rc1, but really, is it needed?
>
> What problem does this renaming solve?

To me, it's a leftover from commit 312c004d36ce that made the rename at
driver core. With this patch, the define will be more matching its user
request_firmware_nowait(..., bool uevent, ...).

> Who is the current name
> confusing?

I'm one at least :)

Shawn

\
 
 \ /
  Last update: 2021-04-25 10:38    [W:0.087 / U:1.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site