lkml.org 
[lkml]   [2021]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] dmaengine: fsl-qdma: check dma_set_mask return value
On 23-04-21, 17:29, Robin Gong wrote:
> For fix warning reported by static code analysis tool like Coverity from
> Synopsys.

Please mention which warning, also Coverity id
Do see other patches which add coverity ids

>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/dma/fsl-qdma.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index ed2ab46..86c02b6 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev)
> fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
> fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;
>
> - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> + if (ret) {
> + dev_err(&pdev->dev, "dma_set_mask failure.\n");
> + return ret;
> + }
>
> platform_set_drvdata(pdev, fsl_qdma);
>
> --
> 2.7.4

--
~Vinod

\
 
 \ /
  Last update: 2021-04-25 18:20    [W:0.049 / U:3.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site