lkml.org 
[lkml]   [2021]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fs: direct-io: Remove redundant assignment to retval
Date
Variable retval is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

fs/direct-io.c:1245:2: warning: Value stored to 'retval' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/direct-io.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index b2e86e7..b348264 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1242,7 +1242,6 @@ static inline int drop_refcount(struct dio *dio)
*/
inode_dio_begin(inode);

- retval = 0;
sdio.blkbits = blkbits;
sdio.blkfactor = i_blkbits - blkbits;
sdio.block_in_file = offset >> blkbits;
--
1.8.3.1
\
 
 \ /
  Last update: 2021-04-25 12:35    [W:0.061 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site