Messages in this thread | | | Subject | Re: [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning | From | Joe Perches <> | Date | Fri, 23 Apr 2021 23:11:05 -0700 |
| |
On Sat, 2021-04-24 at 08:00 +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 23, 2021 at 08:56:19PM +0530, Ashish Kalra wrote: > > On Thu, Apr 22, 2021 at 10:43:13AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 20, 2021 at 02:31:42PM +0530, Ashish Kalra wrote: > > > > Upon running sparse, "warning: incorrect type in argument 1 (different address spaces) > > > > is brought to notice for this file.let's add correct typecast to make it cleaner and > > > > silence the Sparse warning. [] > > struct p80211ioctl_req { > > char name[WLAN_DEVNAMELEN_MAX]; > > - caddr_t data; > > + void __user *data; > > > > Does this looks ok to you and is there any other check possible if this is ok? > > Wait, what is "caddr_t"? Try unwinding that mess first...
Might not be that simple.
include/linux/types.h:typedef __kernel_caddr_t caddr_t; include/uapi/linux/coda.h:typedef void * caddr_t; include/uapi/asm-generic/posix_types.h:typedef char * __kernel_caddr_t;
| |