lkml.org 
[lkml]   [2021]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 31/78] media: i2c: imx219: use pm_runtime_resume_and_get()
    Date
    Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
    added pm_runtime_resume_and_get() in order to automatically handle
    dev->power.usage_count decrement on errors.

    Use the new API, in order to cleanup the error check logic.

    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    ---
    drivers/media/i2c/imx219.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
    index 1054ffedaefd..74a0bf9b088b 100644
    --- a/drivers/media/i2c/imx219.c
    +++ b/drivers/media/i2c/imx219.c
    @@ -1035,11 +1035,9 @@ static int imx219_start_streaming(struct imx219 *imx219)
    const struct imx219_reg_list *reg_list;
    int ret;

    - ret = pm_runtime_get_sync(&client->dev);
    - if (ret < 0) {
    - pm_runtime_put_noidle(&client->dev);
    + ret = pm_runtime_resume_and_get(&client->dev);
    + if (ret < 0)
    return ret;
    - }

    /* Apply default values of current mode */
    reg_list = &imx219->mode->reg_list;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-24 08:50    [W:4.245 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site