lkml.org 
[lkml]   [2021]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/78] media: mtk-vcodec: fix pm_runtime_get_sync() usage count
    Date
    The pm_runtime_get_sync() internally increments the
    dev->power.usage_count without decrementing it, even on errors.
    replace it by the new pm_runtime_resume_and_get(), introduced by:
    commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
    in order to properly decrement the usage counter and avoid memory
    leaks.

    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    ---
    drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    index ddee7046ce42..fe096fe61c9d 100644
    --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
    @@ -92,9 +92,9 @@ void mtk_vcodec_dec_pw_on(struct mtk_vcodec_pm *pm)
    {
    int ret;

    - ret = pm_runtime_get_sync(pm->dev);
    + ret = pm_runtime_resume_and_get(pm->dev);
    if (ret)
    - mtk_v4l2_err("pm_runtime_get_sync fail %d", ret);
    + mtk_v4l2_err("pm_runtime_resume_and_get fail %d", ret);
    }

    void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-24 08:48    [W:4.635 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site