lkml.org 
[lkml]   [2021]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/14] spi: pxa2xx: Use one point of return when ->probe() fails
    Date
    When we can't allocate SPI controller, jump to the error path rather than
    return locally.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/spi/spi-pxa2xx.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
    index 0cc767283674..0ef22045b006 100644
    --- a/drivers/spi/spi-pxa2xx.c
    +++ b/drivers/spi/spi-pxa2xx.c
    @@ -1701,8 +1701,8 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)

    if (!controller) {
    dev_err(&pdev->dev, "cannot alloc spi_controller\n");
    - pxa_ssp_free(ssp);
    - return -ENOMEM;
    + status = -ENOMEM;
    + goto out_error_controller_alloc;
    }
    drv_data = spi_controller_get_devdata(controller);
    drv_data->controller = controller;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-04-23 20:24    [W:4.179 / U:0.888 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site