lkml.org 
[lkml]   [2021]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/3] net: marvell: prestera: bump supported firmware version to 3.0
Hi Andrew,

On Fri, Apr 23, 2021 at 06:49:01PM +0200, Andrew Lunn wrote:
> On Fri, Apr 23, 2021 at 06:59:31PM +0300, Vadym Kochan wrote:
> > From: Vadym Kochan <vkochan@marvell.com>
> >
> > New firmware version has some ABI and feature changes like:
> >
> > - LAG support
> > - initial L3 support
> > - changed events handling logic
> >
> > Signed-off-by: Vadym Kochan <vkochan@marvell.com>
> > ---
> > drivers/net/ethernet/marvell/prestera/prestera_pci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> > index 298110119272..80fb5daf1da8 100644
> > --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> > +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> > @@ -13,7 +13,7 @@
> >
> > #define PRESTERA_MSG_MAX_SIZE 1500
> >
> > -#define PRESTERA_SUPP_FW_MAJ_VER 2
> > +#define PRESTERA_SUPP_FW_MAJ_VER 3
> > #define PRESTERA_SUPP_FW_MIN_VER 0
>
> I could be reading the code wrong, but it looks like anybody with
> firmware version 2 on their machine and this new driver version
> results in the switch not probing? And if the switch does not probe,
> do they have any networking to go get the new firmware version?
>

Existing boards have management port which is separated from the PP.

> I think you need to provide some degree of backwards compatibly to
> older firmware. Support version 2 and 3. When version 4 comes out,
> drop support for version 2 in the driver etc.
>
> Andrew

\
 
 \ /
  Last update: 2021-04-23 19:05    [W:0.116 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site