Messages in this thread | | | Date | Fri, 23 Apr 2021 17:08:41 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces |
| |
On Fri, Apr 23, 2021 at 03:45:56PM +0200, Rasmus Villemoes wrote: > On 23/04/2021 15.24, Andy Shevchenko wrote: > > On Thu, Apr 22, 2021 at 04:46:40PM -0700, Stephen Boyd wrote: > > >>>> +#include <linux/kernel.h> > >>> > >>> What do you need this header for? > >>> > >> > >> For typeof_member(). > > > > Argh... We really need to split this and container_of to something else. Having > > entire kernel.h for that is an overkill. > > > > Yeah, we should have a type-macros.h (or type-helpers or whatever) that > doesn't include any other kernel headers, just stddef.h (which is > compiler-provided) for offsetof(), providing > > typeof_member > sizeof_member > container_of > same_type > type_min > type_max > is_signed_type > __choose_type > > or whatever their names are currently.
Put in my TODO list. Not sure when it will go, though.
-- With Best Regards, Andy Shevchenko
| |