lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 085/190] Revert "audit: fix a memory leak bug"
    On Wed, Apr 21, 2021 at 12:18:44PM -0400, Paul Moore wrote:
    > On Wed, Apr 21, 2021 at 9:04 AM Greg Kroah-Hartman
    > <gregkh@linuxfoundation.org> wrote:
    > >
    > > This reverts commit 70c4cf17e445264453bc5323db3e50aa0ac9e81f.
    > >
    > > Commits from @umn.edu addresses have been found to be submitted in "bad
    > > faith" to try to test the kernel community's ability to review "known
    > > malicious" changes. The result of these submissions can be found in a
    > > paper published at the 42nd IEEE Symposium on Security and Privacy
    > > entitled, "Open Source Insecurity: Stealthily Introducing
    > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > > of Minnesota) and Kangjie Lu (University of Minnesota).
    > >
    > > Because of this, all submissions from this group must be reverted from
    > > the kernel tree and will need to be re-reviewed again to determine if
    > > they actually are a valid fix. Until that work is complete, remove this
    > > change to ensure that no problems are being introduced into the
    > > codebase.
    > >
    > > Cc: Wenwen Wang <wang6495@umn.edu>
    > > Cc: Richard Guy Briggs <rgb@redhat.com>
    > > Cc: Paul Moore <paul@paul-moore.com>
    > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > > ---
    > > kernel/auditfilter.c | 12 +++++-------
    > > 1 file changed, 5 insertions(+), 7 deletions(-)
    >
    > NACK on this revert. I've looked at the original patch again this
    > morning, and the original patch still looks correct and doesn't appear
    > to introduce any new faults to the best of my understanding.
    >

    Thanks for the review, much appreciate it, I'll drop it.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-21 18:29    [W:4.124 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site