lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 176/190] Revert "net/net_namespace: Check the return value of register_pernet_subsys()"
    Date
    This reverts commit 0eb987c874dc93f9c9d85a6465dbde20fdd3884c.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
    Cc: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/net_namespace.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
    index 43b6ac4c4439..9ae0b275238e 100644
    --- a/net/core/net_namespace.c
    +++ b/net/core/net_namespace.c
    @@ -1101,8 +1101,7 @@ static int __init net_ns_init(void)
    init_net_initialized = true;
    up_write(&pernet_ops_rwsem);

    - if (register_pernet_subsys(&net_ns_ops))
    - panic("Could not register network namespace subsystems");
    + register_pernet_subsys(&net_ns_ops);

    rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL,
    RTNL_FLAG_DOIT_UNLOCKED);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:18    [W:4.031 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site