lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 097/190] Revert "video: imsttfb: fix potential NULL pointer dereferences"
    Date
    This reverts commit 1d84353d205a953e2381044953b7fa31c8c9702d.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Finn Thain <fthain@telegraphics.com.au>
    Cc: Rob Herring <robh@kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/imsttfb.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
    index 3ac053b88495..e04411701ec8 100644
    --- a/drivers/video/fbdev/imsttfb.c
    +++ b/drivers/video/fbdev/imsttfb.c
    @@ -1512,11 +1512,6 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    info->fix.smem_start = addr;
    info->screen_base = (__u8 *)ioremap(addr, par->ramdac == IBM ?
    0x400000 : 0x800000);
    - if (!info->screen_base) {
    - release_mem_region(addr, size);
    - framebuffer_release(info);
    - return -ENOMEM;
    - }
    info->fix.mmio_start = addr + 0x800000;
    par->dc_regs = ioremap(addr + 0x800000, 0x1000);
    par->cmap_regs_phys = addr + 0x840000;
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:08    [W:3.728 / U:1.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site