lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 062/190] Revert "scsi: libfc: remove unnecessary assertion on ep variable"
    Date
    This reverts commit 52b894393cecdc303990e834778d39b85d0553fc.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: https
    Cc: Hannes Reinecke <hare@suse.de>
    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/target/tcm_fc/tfc_io.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
    index bbe2e29612fa..15d557a11f63 100644
    --- a/drivers/target/tcm_fc/tfc_io.c
    +++ b/drivers/target/tcm_fc/tfc_io.c
    @@ -220,6 +220,7 @@ void ft_recv_write_data(struct ft_cmd *cmd, struct fc_frame *fp)
    ep = fc_seq_exch(seq);
    lport = ep->lp;
    if (cmd->was_ddp_setup) {
    + BUG_ON(!ep);
    BUG_ON(!lport);
    /*
    * Since DDP (Large Rx offload) was setup for this request,
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:05    [W:2.088 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site