lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 045/190] Revert "usb: gadget: fix potential double-free in m66592_probe."
    Date
    This reverts commit 44734a594196bf1d474212f38fe3a0d37a73278b.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/udc/m66592-udc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
    index 931e6362a13d..75d16a8902e6 100644
    --- a/drivers/usb/gadget/udc/m66592-udc.c
    +++ b/drivers/usb/gadget/udc/m66592-udc.c
    @@ -1667,7 +1667,7 @@ static int m66592_probe(struct platform_device *pdev)

    err_add_udc:
    m66592_free_request(&m66592->ep[0].ep, m66592->ep0_req);
    - m66592->ep0_req = NULL;
    +
    clean_up3:
    if (m66592->pdata->on_chip) {
    clk_disable(m66592->clk);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:05    [W:2.373 / U:0.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site