Messages in this thread | | | Date | Wed, 21 Apr 2021 11:39:12 +0200 | From | Simon Horman <> | Subject | Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang |
| |
On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote: > On 3/5/21 06:19, Simon Horman wrote: > > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > >> by explicitly adding a break statement instead of letting the code fall > >> through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > > Thanks Gustavo, > > > > this looks good to me. > > > > Acked-by: Simon Horman <simon.horman@netronome.com> > > Hi all, > > Friendly ping: who can take this, please?
Hi Jakub, Hi David,
I'm happy to repost this patch if it would help with your processes.
> >> --- > >> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> index b3cabc274121..3b8e675087de 100644 > >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) > >> case NFP_PORT_PF_PORT: > >> case NFP_PORT_VF_PORT: > >> nfp_repr_vnic_get_stats64(repr->port, stats); > >> + break; > >> default: > >> break; > >> } > >> -- > >> 2.27.0 > >>
| |