Messages in this thread | | | Date | Wed, 21 Apr 2021 10:46:41 +0200 | From | Oscar Salvador <> | Subject | Re: [PATCH v9 4/8] mm,memory_hotplug: Allocate memmap from the added memory range |
| |
On Wed, Apr 21, 2021 at 10:39:16AM +0200, Michal Hocko wrote: > Not that I would insist but I find it better to use common constructs > when it doesn't hurt readability. The order evaluation can be even done > in a trivial helper.
Uhm, I will have a look how it looks. Maybe with a nice comment explaining what is going on can make it in. If not, I can always keep what we have atm.
> As I've said I will not insist and this can be done in the follow up. > You are iterating over memory blocks just to refuse to do an operation > which can be split to several memory blocks. See > http://lkml.kernel.org/r/YFtPxH0CT5QZsnR1@dhcp22.suse.cz and follow > walk_memory_blocks(start, size, NULL, remove_memory_block_cb)
Ok, thanks for the link. I will have a look, but I would rather do it as a follow-up.
-- Oscar Salvador SUSE L3
| |