Messages in this thread | | | Subject | Re: [PATCH 170/190] Revert "net: dsa: bcm_sf2: Propagate error value from mdio_write" | From | Florian Fainelli <> | Date | Wed, 21 Apr 2021 16:20:24 -0700 |
| |
On 4/21/2021 6:00 AM, Greg Kroah-Hartman wrote: > This reverts commit e49505f7255be8ced695919c08a29bf2c3d79616. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
While this commit does not fix a known problem, the driver should have arguably propagated the return values and it did not, so I would be inclined to keep it. -- Florian
| |