Messages in this thread | | | Subject | Re: [PATCH 000/190] Revertion of all of the umn.edu commits | From | Krzysztof Kozlowski <> | Date | Wed, 21 Apr 2021 20:08:31 +0200 |
| |
On 21/04/2021 19:48, Al Viro wrote: > On Wed, Apr 21, 2021 at 08:59:34AM -0700, Guenter Roeck wrote: >> On 4/21/21 8:21 AM, Kangjie Lu wrote: >> >>> All of the commits sent by my students are in good faith to fix some bugs. > > > Just to make sure - does that statement cover the following commit? > > commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 > Author: Aditya Pakki <pakki001@umn.edu> > Date: Tue Apr 6 19:09:12 2021 -0500 > > net/rds: Avoid potential use after free in rds_send_remove_from_sock > > And is "Ph.D. student in Computer Science" an accurate description of > the gentleman in question? > > We all made utterly bonehead mistakes (if you want a fresh example > of mine, take a look at 161aff1d93ab "LOOKUP_MOUNTPOINT: fold > path_mountpointat() into path_lookupat()"; see 035d80695fae for the > merge of the fix and explanation of what was wrong in the original > commit). > > However, there's a general expectation that once you become aware of > dumb mistake in something you have published (and merge into mainline > certainly qualifies as publication) you shall retract it as soon > as possible. If a student is not aware of such expectation, their > advisor really ought to inform them of it.
Mentioned gentleman was also notified on 8th of April with Coverity report that his patch is questionable: https://lore.kernel.org/linux-next/202104081640.1A09A99900@keescook/
The report was ignored by the patch author.
Best regards, Krzysztof
| |