Messages in this thread | | | Date | Wed, 21 Apr 2021 13:21:30 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode |
| |
On Wed, Apr 21, 2021 at 05:16:24PM +0100, Matthew Wilcox wrote: > On Wed, Apr 21, 2021 at 11:56:31AM -0400, Vivek Goyal wrote: > > +/** > > + * enum dax_entry_wake_mode: waitqueue wakeup toggle > > s/toggle/behaviour/ ?
Will do.
> > > + * @WAKE_NEXT: wake only the first waiter in the waitqueue > > + * @WAKE_ALL: wake all waiters in the waitqueue > > + */ > > +enum dax_entry_wake_mode { > > + WAKE_NEXT, > > + WAKE_ALL, > > +}; > > + > > static wait_queue_head_t *dax_entry_waitqueue(struct xa_state *xas, > > void *entry, struct exceptional_entry_key *key) > > { > > @@ -182,7 +192,8 @@ static int wake_exceptional_entry_func(w > > * The important information it's conveying is whether the entry at > > * this index used to be a PMD entry. > > */ > > -static void dax_wake_entry(struct xa_state *xas, void *entry, bool wake_all) > > +static void dax_wake_entry(struct xa_state *xas, void *entry, > > + enum dax_entry_wake_mode mode) > > It's an awfully verbose name. 'dax_wake_mode'?
Sure. Will change.
Vivek >
| |