Messages in this thread | | | Date | Tue, 20 Apr 2021 10:35:23 +0200 | From | Fabio Aiuto <> | Subject | Re: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level |
| |
Hi Deepak,
On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote: > printk() without KERN_<LEVEL> facility is flagged by checkpatch as a > warning. It is better to use pr_info() which comes with an > inbuilt KERN_INFO level. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > index b572551f1a0d..a0f3c5c32f94 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > @@ -1020,7 +1020,7 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd, > return -EINVAL; > } > > - printk("%s: before gc0310_write_reg_array %s\n", __func__, > + pr_info("%s: before gc0310_write_reg_array %s\n", __func__, > gc0310_res[dev->fmt_idx].desc);
in a driver is best recommended to replace a raw printk call with a dev_*() log. Check few lines above here to see how it is done.
> ret = startup(sd); > if (ret) { > -- > 2.25.1 > >
thank you,
fabio
| |