Messages in this thread | | | Subject | Re: [RESEND PATCH] bus: mhi: core: Remove pre_init flag used for power purposes | From | Hemant Kumar <> | Date | Fri, 2 Apr 2021 11:20:27 -0700 |
| |
On 4/1/21 2:41 PM, Bhaumik Bhatt wrote: > Some controllers can choose to skip preparation for power up. > In that case, device context is initialized based on the pre_init > flag not being set during mhi_prepare_for_power_up(). There is no > reason MHI host driver should maintain and provide controllers > with two separate paths for preparing MHI. > > Going forward, all controllers will be required to call the > mhi_prepare_for_power_up() API followed by their choice of sync > or async power up. This allows MHI host driver to get rid of the > pre_init flag and sets up a common way for all controllers to use > MHI. This also helps controllers fail early on during preparation > phase in some failure cases. > > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> > --- > This patch was tested on arm64 architecture.
Change looks good as current MHI controllers ath11k and pci generic are not using pre_init.
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |