lkml.org 
[lkml]   [2021]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 15/19] regulator: Support ROHM BD71815 regulators
On Mon, Mar 29, 2021 at 03:59:51PM +0300, Matti Vaittinen wrote:

Acked-by: Mark Brown <broonie@kernel.org>

but...

> @@ -0,0 +1,676 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2014 Embest Technology Co. Ltd. Inc.

Please make the entire comment a C++ one so things look more
intentional.

> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

A regulator driver generally shouldn't need machine interfaces...

> + ret = regulator_enable_regmap(rdev);
> + else
> + ret = regulator_disable_regmap(rdev);
> +
> + if (ret)
> + dev_err(rdev_get_dev(rdev),
> + "LED status error\n");

Better to print the error code, and that error message could be a bit
more descriptive.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-04-02 19:42    [W:0.326 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site