Messages in this thread | | | Date | Fri, 2 Apr 2021 18:18:32 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH v3 4/7] regulator: add property parsing and callbacks to set protection limits |
| |
On Thu, Mar 11, 2021 at 12:23:02PM +0200, Matti Vaittinen wrote:
> + /* > + * Existing logic does not warn if over_current_protection is given as > + * a constraint but driver does not support that. I think we should > + * warn about this type of issues as it is possible someone changes
The "existing logic" bit here is for a changelog, not the code - as soon as the patch is applied the comment becomes inaccurate. This also seems like a separate patch. [unhandled content-type:application/pgp-signature] | |