Messages in this thread | | | Date | Fri, 2 Apr 2021 16:23:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: max98390: Add controls for tx path |
| |
On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote:
> + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, > + 0, 255, 0),
I'm not clear what this is (especially given the source selection below) but it looks like it should be a mute control?
> + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, > + 0, 255, 0),
This I'd expect to be tied into machine driver configuration, either DT properties or TDM slot configuration - it's not something that looks like it's something you'd want to control at runtime.
> + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, > + 0, 255, 0),
This looks like it should be a DAPM control or possibly a TDM slot configuration - look at how the Arizona devices handle routing from multiple TDM slots for the DAPM version. [unhandled content-type:application/pgp-signature] | |