lkml.org 
[lkml]   [2021]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: max98390: Add controls for tx path
On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote:

> + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A,
> + 0, 255, 0),

I'm not clear what this is (especially given the source selection below)
but it looks like it should be a mute control?

> + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A,
> + 0, 255, 0),

This I'd expect to be tied into machine driver configuration, either DT
properties or TDM slot configuration - it's not something that looks
like it's something you'd want to control at runtime.

> + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2,
> + 0, 255, 0),

This looks like it should be a DAPM control or possibly a TDM slot
configuration - look at how the Arizona devices handle routing from
multiple TDM slots for the DAPM version.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-04-02 17:24    [W:0.130 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site