lkml.org 
[lkml]   [2021]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf inject: Fix repipe usage
    Em Thu, Apr 01, 2021 at 04:05:13PM +0200, Jiri Olsa escreveu:
    > On Thu, Apr 01, 2021 at 01:36:05PM +0300, Adrian Hunter wrote:
    > > Since commit 14d3d5405253 ("perf session: Try to read pipe data from file")
    > > perf inject has started printing "PERFILE2h" when not processing pipes.
    > >
    > > The commit exposed perf to the possiblity that the input is not a pipe but
    > > the 'repipe' parameter gets used. That causes the printing because perf
    > > inject sets 'repipe' to true always.
    > >
    > > The 'repipe' parameter of perf_session__new() is used by 2 functions:
    > > - perf_file_header__read_pipe()
    > > - trace_report()
    > > In both cases, the functions copy data to STDOUT_FILENO when 'repipe' is
    > > true.
    > >
    > > Fix by setting 'repipe' to true only if the output is a pipe.
    > >
    > > Fixes: e558a5bd8b74 ("perf inject: Work with files")
    > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    >
    > Acked-by: Jiri Olsa <jolsa@redhat.com>

    Thanks, applied.

    - Arnaldo

    \
     
     \ /
      Last update: 2021-04-02 15:33    [W:2.429 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site