Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next] KEYS: trusted: Switch to kmemdup_nul() | Date | Fri, 2 Apr 2021 17:23:46 +0800 |
| |
Use kmemdup_nul() helper instead of open-coding to simplify the code.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- security/keys/trusted-keys/trusted_tpm1.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c index 493eb91ed017..90ded4757e79 100644 --- a/security/keys/trusted-keys/trusted_tpm1.c +++ b/security/keys/trusted-keys/trusted_tpm1.c @@ -978,11 +978,9 @@ static int trusted_instantiate(struct key *key, if (datalen <= 0 || datalen > 32767 || !prep->data) return -EINVAL; - datablob = kmalloc(datalen + 1, GFP_KERNEL); + datablob = kmemdup_nul(prep->data, datalen, GFP_KERNEL); if (!datablob) return -ENOMEM; - memcpy(datablob, prep->data, datalen); - datablob[datalen] = '\0'; options = trusted_options_alloc(); if (!options) { -- 2.25.1
| |