Messages in this thread | | | Date | Fri, 2 Apr 2021 20:03:56 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH RESEND] random: initialize ChaCha20 constants with correct endianness |
| |
On Sun, Mar 21, 2021 at 10:13:47PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > On big endian CPUs, the ChaCha20-based CRNG is using the wrong > endianness for the ChaCha20 constants. > > This doesn't matter cryptographically, but technically it means it's not > ChaCha20 anymore. Fix it to always use the standard constants. > > Cc: linux-crypto@vger.kernel.org > Cc: Andy Lutomirski <luto@kernel.org> > Cc: Jann Horn <jannh@google.com> > Cc: Theodore Ts'o <tytso@mit.edu> > Acked-by: Herbert Xu <herbert@gondor.apana.org.au> > Acked-by: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Eric Biggers <ebiggers@google.com> > --- > drivers/char/random.c | 4 ++-- > include/crypto/chacha.h | 9 +++++++-- > 2 files changed, 9 insertions(+), 4 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |