lkml.org 
[lkml]   [2021]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/40] include: drm: drm_atomic: Make use of 'new_plane_state'
    Date
    In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided
    as a container for state->planes[i].new_state, but is not utilised in
    some use-cases, so we fake-use it instead.

    Fixes the following W=1 kernel build warning(s):

    drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_commit_cursors’:
    drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7649:44: warning: variable ‘new_plane_state’ set but not used [-Wunused-but-set-variable]

    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Maxime Ripard <mripard@kernel.org>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: Rob Clark <robdclark@gmail.com>
    Cc: dri-devel@lists.freedesktop.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    include/drm/drm_atomic.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
    index ac5a28eff2c86..259e6970dc836 100644
    --- a/include/drm/drm_atomic.h
    +++ b/include/drm/drm_atomic.h
    @@ -871,7 +871,8 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p);
    ((plane) = (__state)->planes[__i].ptr, \
    (void)(plane) /* Only to avoid unused-but-set-variable warning */, \
    (old_plane_state) = (__state)->planes[__i].old_state,\
    - (new_plane_state) = (__state)->planes[__i].new_state, 1))
    + (new_plane_state) = (__state)->planes[__i].new_state, \
    + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1))

    /**
    * for_each_oldnew_plane_in_state_reverse - iterate over all planes in an atomic
    --
    2.27.0
    \
     
     \ /
      Last update: 2021-04-16 16:38    [W:3.969 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site