Messages in this thread | | | Date | Fri, 16 Apr 2021 21:33:26 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance |
| |
On Sat, Apr 10, 2021 at 05:50:32PM +0800, Hui Tang wrote: > 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not > necessary to do it here, so remove it. > > It should return error immediately when return value of 'hpre_cfg_by_dsm' > is non-zero, and no need to execute the remaining sentences. > > Signed-off-by: Hui Tang <tanghui20@huawei.com> > > --- > v1 -> v2: > - Return immediately when return value of 'hpre_cfg_by_dsm' is > non-zero. > v2 -> v3: > - Add description for return if function fails. > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |