Messages in this thread | | | Subject | Re: [PATCH] soc: fsl: qe: remove unused function | From | Christophe Leroy <> | Date | Fri, 16 Apr 2021 09:06:23 +0200 |
| |
Le 16/04/2021 à 08:57, Daniel Axtens a écrit : > Hi Jiapeng, > >> Fix the following clang warning:
You are not fixing a warning, you are removing a function in order to fix a warning ...
>> >> drivers/soc/fsl/qe/qe_ic.c:234:29: warning: unused function >> 'qe_ic_from_irq' [-Wunused-function].
Would be wise to tell that the last users of the function where removed by commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions")
https://github.com/torvalds/linux/commit/d7c2878cfcfa
>> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >> --- >> drivers/soc/fsl/qe/qe_ic.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c >> index 0390af9..b573712 100644 >> --- a/drivers/soc/fsl/qe/qe_ic.c >> +++ b/drivers/soc/fsl/qe/qe_ic.c >> @@ -231,11 +231,6 @@ static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, >> qe_iowrite32be(value, base + (reg >> 2)); >> } >> >> -static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) >> -{ >> - return irq_get_chip_data(virq); >> -} > > This seems good to me. > > * We know that this function can't be called directly from outside the > file, because it is static. > > * The function address isn't used as a function pointer anywhere, so > that means it can't be called from outside the file that way (also > it's inline, which would make using a function pointer unwise!) > > * There's no obvious macros in that file that might construct the name > of the function in a way that is hidden from grep. > > All in all, I am fairly confident that the function is indeed not used. > > Reviewed-by: Daniel Axtens <dja@axtens.net> > > Kind regards, > Daniel > >> - >> static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d) >> { >> return irq_data_get_irq_chip_data(d); >> -- >> 1.8.3.1
| |