lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 55/68] net: ieee802154: fix nl802154 del llsec devkey
    Date
    From: Alexander Aring <aahringo@redhat.com>

    commit 27c746869e1a135dffc2f2a80715bb7aa00445b4 upstream.

    This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is
    not set by the user. If this is the case nl802154 will return -EINVAL.

    Reported-by: syzbot+368672e0da240db53b5f@syzkaller.appspotmail.com
    Signed-off-by: Alexander Aring <aahringo@redhat.com>
    Link: https://lore.kernel.org/r/20210221174321.14210-4-aahringo@redhat.com
    Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ieee802154/nl802154.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/ieee802154/nl802154.c
    +++ b/net/ieee802154/nl802154.c
    @@ -1943,7 +1943,8 @@ static int nl802154_del_llsec_devkey(str
    struct ieee802154_llsec_device_key key;
    __le64 extended_addr;

    - if (nla_parse_nested(attrs, NL802154_DEVKEY_ATTR_MAX,
    + if (!info->attrs[NL802154_ATTR_SEC_DEVKEY] ||
    + nla_parse_nested(attrs, NL802154_DEVKEY_ATTR_MAX,
    info->attrs[NL802154_ATTR_SEC_DEVKEY],
    nl802154_devkey_policy, info->extack))
    return -EINVAL;

    \
     
     \ /
      Last update: 2021-04-15 17:09    [W:6.988 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site