Messages in this thread | | | Subject | Re: [PATCH] sched,psi: fix the 'int' underflow for psi | From | Charan Teja Kalla <> | Date | Thu, 15 Apr 2021 20:25:32 +0530 |
| |
Thanks Johannes!!
On 4/15/2021 8:12 PM, Johannes Weiner wrote: > Makes sense, it's more graceful in the event of a bug. > > But what motivates this change? Is it something you hit recently with > an upstream kernel and we should investigate?
We specifically didn't hit the issue around this change. Identified this while doing code walk through.
> > There is already a branch on the tasks to signal the bug. How about: > > if (groupc->tasksk[t]) { > groupc->tasks[t]--; > } else if (!psi_bug) { > printk_deferred(... > psi_bug = 1; > }
Looks cleaner. Will raise V2 with this. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |