lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched,psi: fix the 'int' underflow for psi
From
Date
Thanks Johannes!!

On 4/15/2021 8:12 PM, Johannes Weiner wrote:
> Makes sense, it's more graceful in the event of a bug.
>
> But what motivates this change? Is it something you hit recently with
> an upstream kernel and we should investigate?

We specifically didn't hit the issue around this change. Identified this
while doing code walk through.

>
> There is already a branch on the tasks to signal the bug. How about:
>
> if (groupc->tasksk[t]) {
> groupc->tasks[t]--;
> } else if (!psi_bug) {
> printk_deferred(...
> psi_bug = 1;
> }

Looks cleaner. Will raise V2 with this.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2021-04-15 17:06    [W:0.050 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site