Messages in this thread | | | From | Vincent MAILHOL <> | Date | Thu, 15 Apr 2021 20:42:36 +0900 | Subject | Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer |
| |
On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde <mkl@pengutronix.de> wrote: > On 15.04.2021 09:47:23, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > There is an assignment to *netdev that is can potentially be null but the ^^ Typo: that is can -> that can
> > null check is checking netdev and not *netdev as intended. Fix this by > > adding in the missing * operator. > > > > Addresses-Coverity: ("Dereference before null check") > > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Thanks Colin!
| |