lkml.org 
[lkml]   [2021]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer
On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 15.04.2021 09:47:23, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is an assignment to *netdev that is can potentially be null but the
^^
Typo: that is can -> that can

> > null check is checking netdev and not *netdev as intended. Fix this by
> > adding in the missing * operator.
> >
> > Addresses-Coverity: ("Dereference before null check")
> > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Thanks Colin!

\
 
 \ /
  Last update: 2021-04-15 13:44    [W:0.038 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site